Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision datasets.kitti_dataset.KittiDataset #896

Merged
merged 7 commits into from
Oct 5, 2022

Conversation

lijm1358
Copy link
Contributor

@lijm1358 lijm1358 commented Oct 4, 2022

What does this PR do?

Related to #839

  • Update docstring for KittiDataset
  • Remove void_labels in argument and set it related to valid_labels
  • Add test for KittiDataset with random image

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@lijm1358
Copy link
Contributor Author

lijm1358 commented Oct 5, 2022

Hi, I've reviewed KittiDataset and added test for it, but I'm not really sure about the test. I wanted to test KittiDataset with original KITTI segmentation dataset, but it should be downloaded manually with signin. At first, I tried to download dataset manually in the data_dir and set to skip test(@pytest.mark.skipif) if downloaded KITTI dataset is not found in data_dir, but it seems not a proper way to test. So I added code to create randomly generated image and mask with same directory, name, and classes as the original dataset, and tested KittiDataset with this image. Is it ok to do so, or is there any proper way to test KittiDataset without manual downloading? Thanks 😀

@lijm1358 lijm1358 marked this pull request as ready for review October 5, 2022 03:54
@otaj
Copy link
Contributor

otaj commented Oct 5, 2022

That's a tricky one, but I'd say that the way you tested is just fine - KITTI dataset is quite old, so it has very fixed structure, so generating random things inside that well-known structure is just fine.

@otaj otaj enabled auto-merge (squash) October 5, 2022 09:36
@mergify mergify bot added the ready label Oct 5, 2022
@otaj otaj merged commit 79c6e24 into Lightning-Universe:master Oct 5, 2022
@otaj otaj mentioned this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants